Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: Remove the NOT_BUILT scenario #144

Open
1 of 4 tasks
MadsNielsen opened this issue Mar 20, 2020 · 4 comments
Open
1 of 4 tasks

Goal: Remove the NOT_BUILT scenario #144

MadsNielsen opened this issue Mar 20, 2020 · 4 comments

Comments

@MadsNielsen
Copy link
Member

MadsNielsen commented Mar 20, 2020

Subtasks

  • No branch should return latest integration branch (Use remote integration branch on no branch trigger #143)
  • Triggered branch is the same as integration branch
  • Triggered branch is behind the integration branch
  • Triggered branch is behind the integration branch should be configurable (Optional)
@bicschneider
Copy link
Contributor

image

@NKJensen
Copy link

NKJensen commented Mar 20, 2020

Perhaps consider to write "Missing branch" in stead of "No branch" ? The "Triggered branch is the same as integration branch" is IMHO a null-operation, just return master for building.

@NKJensen
Copy link

"Triggered branch is behind the integration branch" - this could be halted in the pre-receive hook. It would be OK to return "master" in case someone sends in a "historical" commit on a ready-branch

@NKJensen
Copy link

I mean - don't make an option for "Triggered branch is behind the integration branch" - if it is a problem in your organization, use the pre-receive hook. It will be much easier for new developers to understand at that time in the process, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants