Merge pull request #132 from dreamteam-gg/suppress-diff-secrets

Adding ability to suppress secrets in helm diff output, UnmarshalStrict for YAML

decision_maker.go

@@ -219,13 +219,17 @@ func diffRelease(r *release) string {
 	exitCode := 0
 	msg := ""
 	colorFlag := ""
+	suppressDiffSecretsFlag := ""
 	if noColors {
 		colorFlag = "--no-color "
 	}
+	if suppressDiffSecrets {
+		suppressDiffSecretsFlag = "--suppress-secrets "
+	}
 
 	cmd := command{
 		Cmd:         "bash",
-		Args:        []string{"-c", "helm diff " + colorFlag + "upgrade " + r.Name + " " + r.Chart + getValuesFiles(r) + " --version " + strconv.Quote(r.Version) + " " + getSetValues(r) + getSetStringValues(r) + getDesiredTillerNamespaceFlag(r) + getTLSFlags(r) + getNoHooks(r)},
+		Args:        []string{"-c", "helm diff " + colorFlag + suppressDiffSecretsFlag + "upgrade " + r.Name + " " + r.Chart + getValuesFiles(r) + " --version " + strconv.Quote(r.Version) + " " + getSetValues(r) + getSetStringValues(r) + getDesiredTillerNamespaceFlag(r) + getTLSFlags(r)},
 		Description: "diffing release [ " + r.Name + " ] using Tiller in [ " + getDesiredTillerNamespace(r) + " ]",
 	}
 

init.go

@@ -55,6 +55,7 @@ func init() {
 	flag.BoolVar(&applyLabels, "apply-labels", false, "apply Helmsman labels to Helm state for all defined apps.")
 	flag.BoolVar(&keepUntrackedReleases, "keep-untracked-releases", false, "keep releases that are managed by Helmsman and are no longer tracked in your desired state.")
 	flag.BoolVar(&showDiff, "show-diff", false, "show helm diff results. Can expose sensitive information.")
+	flag.BoolVar(&suppressDiffSecrets, "suppress-diff-secrets", false, "don't show secrets in helm diff output.")
 
 	flag.Usage = printUsage
 	flag.Parse()

main.go

@@ -39,6 +39,7 @@ var kubectlVersion string
 var dryRun bool
 var destroy bool
 var showDiff bool
+var suppressDiffSecrets bool
 
 func main() {
 	// set the kubecontext to be used Or create it if it does not exist

utils.go

@@ -86,7 +86,7 @@ func fromYAML(file string, s *state) (bool, string) {
 		return false, err.Error()
 	}
 	yamlFile := []byte(substituteEnv(string(rawYamlFile)))
-	if err = yaml.Unmarshal(yamlFile, s); err != nil {
+	if err = yaml.UnmarshalStrict(yamlFile, s); err != nil {
 		return false, err.Error()
 	}