Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify a path on Ingress objects for Jira and Confluence helm charts. #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Atchuu
Copy link

@Atchuu Atchuu commented Nov 13, 2019

Adding the ability to specify a path to the ingress templates for both Jira and Confluence. The templates and were changed in such a way as to be backwards compatible while allowing the ability to specify a path if desired.

@hoeghh
Copy link
Contributor

hoeghh commented Dec 9, 2019

Hi @Atchuu
Thank you so much. We rarly use context paths, so we didnt implement it. But it should, so thank you.

I will test this as soon as possible.

@hoeghh hoeghh self-assigned this Dec 16, 2019
@hoeghh
Copy link
Contributor

hoeghh commented Dec 16, 2019

Hi @Atchuu

From the viewpoint of helm and ingress, this pull request is fine.

The problem is that it only deals with the kubernetes side of the task. We still need to make the change to server.xml.

If i could get you to do those changes as well, and thereby finishing the taks we can do the merge.

Changes needs to be done to server.xml for both jira and confluence as per this guide :
https://confluence.atlassian.com/jirakb/change-the-context-path-used-to-access-jira-server-225119408.html

in the docker-entrypoint.sh script found here
https://github.com/Praqma/jira/blob/master/docker-entrypoint.sh and
https://github.com/Praqma/confluence/blob/master/docker-entrypoint.sh

The problem with merging it without that change is, that people will get confused as to why it doesnt work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants