Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 minor - added Dockerfile and mocked up pipeline. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#2 minor - added Dockerfile and mocked up pipeline. #3

wants to merge 1 commit into from

Conversation

Sharor
Copy link

@Sharor Sharor commented Sep 19, 2017

The first part atemtps to run Wincrementor as part of a tollgate

This closes #2 in case of accepted pull req

@Sharor
#2 minor - added Dockerfile and mocked up pipeline. The first part at…
cff5f38 
…temtps to run Wincrementor as part of a tollgate
@Sharor Sharor requested a review from JKrag September 19, 2017 13:53
JKrag
JKrag requested changes Sep 22, 2017
View reviewed changes
Copy link
Member

@JKrag JKrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that 90% of the stuff in the gemfile is not needed. I think we should start with a minimal one instead of relying on a cleanup later.

@Sharor
Copy link
Author

Sharor commented Sep 22, 2017

could you guide me, which ones are necessary? You can just change the file and merge - I agree with that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKrag JKrag JKrag requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need operations stuff (Dockerfile, pipeline)
2 participants
@Sharor @JKrag