Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: White page when switch ts version to 4.4.4 #34

Open
NWYLZW opened this issue Aug 30, 2023 · 6 comments
Open

Bug: White page when switch ts version to 4.4.4 #34

NWYLZW opened this issue Aug 30, 2023 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@NWYLZW
Copy link
Member

NWYLZW commented Aug 30, 2023

image

@NWYLZW NWYLZW added the bug Something isn't working label Aug 30, 2023
@NWYLZW NWYLZW added this to the 0.1.0 milestone Aug 30, 2023
@NWYLZW NWYLZW self-assigned this Aug 30, 2023
@nonzzz
Copy link
Member

nonzzz commented Aug 30, 2023

Unfortunately, 4.4.4 may not have func addCommand. :(

image
In my local devtool. I print it.

@nonzzz
Copy link
Member

nonzzz commented Aug 30, 2023

We need a polyfill to support it.

@nonzzz
Copy link
Member

nonzzz commented Aug 30, 2023

After my testing, versions lower than 4.9.5 will have problems. But the interesting thing is that it has the addcommand API but it is not exposed.

@NWYLZW
Copy link
Member Author

NWYLZW commented Aug 30, 2023

After my testing, versions lower than 4.9.5 will have problems. But the interesting thing is that it has the addcommand API but it is not exposed.

VSCode team is so bad. So we don't need polyfill, just find a way to expose it?

@nonzzz
Copy link
Member

nonzzz commented Aug 30, 2023

yes. Just try expose it :(

@nonzzz
Copy link
Member

nonzzz commented Aug 30, 2023

I find a way. Look at
image
Notice the registerCommand function.

And then
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants