Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting comments on Turbo Intruder request/response objects #68

Open
SafeEval opened this issue Mar 4, 2021 · 2 comments
Open

Setting comments on Turbo Intruder request/response objects #68

SafeEval opened this issue Mar 4, 2021 · 2 comments

Comments

@SafeEval
Copy link

SafeEval commented Mar 4, 2021

Comments set for request/response rows in Proxy and Intruder persist across tools, including plugins like Logger++. I'm trying to programmatically do the same from Turbo Intruder scripts, using BurpRequest.setComment().

I dug into Turbo Intruder's code, to expose this functionality to Python without success.

  • I found that BurpRequest.setComment() is an empty method. (source)
  • A few places in the Java/Kotlin code make use of IHttpRequestResponse objects, so I tried calling setComment with a string literal as a test to see if anything stuck, without luck (MessageController, TurboScanIssue)

I understand that you cannot provide indefinite support, and am willing to take a stab at implementing this. How might I go about wiring up BurpRequest.setComment() so that comments are persisted?

@albinowax
Copy link
Contributor

You could try just adding a comment attribute to BurpRequest and implementing the getter/setter but I'm not sure this would work.

@SafeEval
Copy link
Author

SafeEval commented Mar 7, 2021

Thanks for the suggestion. I tried a few approaches and found one that works, without needing to modify Turbo Intruder itself. It's verbose, but functional.

I registered a new IHttpListener, then exposed the IHttpRequestResponse being passed through the listener to other functions in the script. A PoC can be found here: poc-turbo-intruder-messageinfo-comment.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants