Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Check_OPTIONS.bcheck #202

Merged
merged 4 commits into from
May 1, 2024
Merged

Create Check_OPTIONS.bcheck #202

merged 4 commits into from
May 1, 2024

Conversation

ceramicskate0
Copy link
Contributor

@ceramicskate0 ceramicskate0 commented May 1, 2024 •
edited
Loading

BCheck Contributions

  • BCheck compiles and executes as expected
  • BCheck contains appropriate metadata (name, version, author, description and appropriate tags)
  • Only .bcheck files have been added or modified
  • BCheck is in the appropriate folder
  • PR contains single or limited number of BChecks (Multiple PRs are preferred)
  • BCheck attempts to minimize false positives

Hannah-PortSwigger
Hannah-PortSwigger requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission! It looks good, but we have a small feedback point for you 🙂

other/recon/Check_OPTIONS.bcheck Outdated Show resolved Hide resolved
Hannah-PortSwigger
Hannah-PortSwigger approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

PortSwiggerWiener
PortSwiggerWiener approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@PortSwiggerWiener PortSwiggerWiener merged commit 2bb188b into PortSwigger:main May 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PortSwiggerWiener PortSwiggerWiener PortSwiggerWiener approved these changes

@Hannah-PortSwigger Hannah-PortSwigger Hannah-PortSwigger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceramicskate0 @Hannah-PortSwigger @PortSwiggerWiener