Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request feature - Response timeout #103

Closed
Pyvonix opened this issue Sep 2, 2023 · 6 comments
Closed

Request feature - Response timeout #103

Pyvonix opened this issue Sep 2, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Pyvonix
Copy link

Pyvonix commented Sep 2, 2023

Hi PortSwigger team,

I propose the add a response's keyword: timeout as boolean value to know when the request didn't get a respond from the server for vulns like DOS.

Thank you.

@Hannah-PortSwigger
Copy link
Contributor

Thanks for the feedback! We've raised this as a feature request to be discussed further.

@Hannah-PortSwigger Hannah-PortSwigger added the enhancement New feature or request label Sep 4, 2023
@Hannah-PortSwigger Hannah-PortSwigger mentioned this issue Sep 21, 2023
Closed
@Hannah-PortSwigger Hannah-PortSwigger added the duplicate This issue or pull request already exists label Sep 21, 2023
@Hannah-PortSwigger
Copy link
Contributor

This is a similar feature request to #32 and #72

@Hannah-PortSwigger Hannah-PortSwigger closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
@Pyvonix
Copy link
Author

Pyvonix commented Sep 23, 2023

Hi @Hannah-PortSwigger,

No, this feature is not about the time it takes to make a request (as explain in #32 ).

This enhancement is to provide a boolean to know when a request raises the TimeoutException or not.

Use case:

  • my BCheck made a request,
  • it DOS the backend/server,
  • then, I never receive any response.

Who could I know my rule successfully works?
The sent request will not have any response, so I will not be able to trigger any finding.

This is not the same usage than #32, which expected to test sql time based injection.

@Michelle-PortSwigger
Copy link
Contributor

I'll check with the team exactly which scenarios the feature request here would cover. For example, whether it will cover cases where there is no response from the server as well as delayed responses. I'll be in touch soon with an update.

@Michelle-PortSwigger Michelle-PortSwigger removed the duplicate This issue or pull request already exists label Sep 26, 2023
@Michelle-PortSwigger
Copy link
Contributor

Hi

I've checked with the team this morning, and we do have both scenarios covered in the feature requests we have created for further discussion and are monitoring here. I'll leave this open for now to make it clearer that both enhancements have been logged.

@Pyvonix
Copy link
Author

Pyvonix commented Sep 28, 2023

Thank you,

Waiting to see the new feature to tell you if it covers this usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants