Fix reading/getting env vars

[nlemoine]

putenv/getenv is not thread safe: https://jolicode.com/blog/what-you-need-to-know-about-environment-variables-with-php#thread-safety-of-getenv

[voronkovich]

@nlemoine, I think we should keep getenv() as a fallback, because $_ENV could be disabled with variables_order directive:

; php.ini
variables_order = "GPCS"

$value = $_ENV[$key] ?? getenv($key);

[voronkovich]

I just checked an official php.ini-production. The $_ENV is disabled by default. So I think it's better to use $_SERVER variable instead.

[nlemoine]

Hello @voronkovich,

Thanks you for the prompt feedback!

I just checked an official php.ini-production.

Interesting! However, $_ENV is still widely used and I think I never stumble on a server with E disabled.

Dotenv libraries usually populate both $_SERVER and $_ENV.

I updated the code to read from: $_SERVER, $_ENV, getenv, in that order:

$value = $_SERVER[$key] ?? $_ENV[$key] ?? getenv($key) !== false ?: null;

Checking if E is disabled with ini_get('variable_order') seems overkill IMHO.

Let me know if this looks right to you.

[voronkovich]

@nlemoine, thanks for the contribution!

[nlemoine]

Thanks for considering it!