Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Plasmo outputs incorrect bundle #1134

Open
2 of 3 tasks
michalkvasnicak opened this issue Nov 22, 2024 · 0 comments
Open
2 of 3 tasks

[BUG] Plasmo outputs incorrect bundle #1134

michalkvasnicak opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@michalkvasnicak
Copy link

michalkvasnicak commented Nov 22, 2024

What happened?

During my work on mod-protocol/Frames-Fun-Extension#17 I found an issue that importing anything from @frames.js/render/{any nested path} results in incorrect bundle breaking the extension. Importing from @frames.js/render does not break the extension.

I was thinking whether it is something wrong with our package, but I was able to reproduce the issue in fresh extension repository and it boils down to @farcaster/core dependency being incorrectly inlined.

I also tried downgrading the extension to 0.86.3 but no help with that one as well

Minimum reproducible code

https://github.com/michalkvasnicak/plasmo-incorrect-bundle-reproduction

Screenshots

Error in browser when inspecting popup

screenshot-01

Bundled code

screenshot-02

See the var _utils being declared twice.

Version

Latest

What OS are you seeing the problem on?

MacOSX

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

(OPTIONAL) Contribution

  • I would like to fix this BUG via a PR

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@michalkvasnicak michalkvasnicak added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant