You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In cli/plasmo/src/features/background-service-worker/bgsw-messaging.ts#getHandlerList there is a glob that inadvertently includes external messages when given getHandlerList(manifest, "messages"). The glob should not enter the messages/external folder because messages should only include internal message listeners, not the external message listeners.
How to reproduce:
Create an external message handler, e.g. src/background/external/messages/Test.ts
plasmo build. Note that the build will fail according to the external message handler you added.
Version
Latest
What OS are you seeing the problem on?
MacOSX
What browsers are you seeing the problem on?
Chrome
Relevant log output
🟣 Plasmo v0.89.2
🔴 The Browser Extension Framework
🔵 INFO | Prepare to bundle the extension...
🔵 INFO | Building for target: chrome-mv3
🔵 INFO | Loaded environment variables from: [ '.env.chrome', '.env.production', '.env' ]
🔴 ERROR | Identifier 'messagesExternalTest' has already been declared. (38:20)
### (OPTIONAL) Contribution
- [X] I would like to fix this BUG via a PR
### Code of Conduct
- [X] I agree to follow this project's Code of Conduct
- [X] I checked the [current issues](https://github.com/PlasmoHQ/plasmo/issues?q=is%3Aopen+is%3Aissue+label%3Abug) for duplicate problems.
The text was updated successfully, but these errors were encountered:
What happened?
In cli/plasmo/src/features/background-service-worker/bgsw-messaging.ts#getHandlerList there is a glob that inadvertently includes external messages when given
getHandlerList(manifest, "messages")
. The glob should not enter themessages/external
folder becausemessages
should only include internal message listeners, not the external message listeners.How to reproduce:
src/background/external/messages/Test.ts
Version
Latest
What OS are you seeing the problem on?
MacOSX
What browsers are you seeing the problem on?
Chrome
Relevant log output
The text was updated successfully, but these errors were encountered: