Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution 9 - a demo of working with Timers in Orleans. #202

Closed
wants to merge 3 commits into from
Closed

Add solution 9 - a demo of working with Timers in Orleans. #202

wants to merge 3 commits into from

Conversation

CamiloTerevinto
Copy link
Contributor

Aims to fix #149

@PiotrJustyna
Copy link
Owner

Thanks for taking the initiative Camilo. I should have some time next week to review this.

Copy link
Owner

@PiotrJustyna PiotrJustyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for all the hard work you've invested into this. I left some comments, please let me know what you think.

Also, if you ever want to update the diagram of all solutions, I used Plant UML for it - you can get a VS Code plugin for rendering and exporting diagrams. Current version of the diagram is here: https://github.com/PiotrJustyna/road-to-orleans/blob/main/solutions.puml

9/.dockerignore Outdated Show resolved Hide resolved
9/Grains/src/TimerWorld.cs Outdated Show resolved Hide resolved
@CamiloTerevinto CamiloTerevinto changed the title Add solution 9 - a demo of working with Timers in Orleands. Add solution 9 - a demo of working with Timers in Orleans. May 12, 2021
Copy link
Owner

@PiotrJustyna PiotrJustyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, the change looks more compact than the last iteration. Left some comments, nothing major.

9/run-demo-load-test.sh Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
9/readme.md Outdated Show resolved Hide resolved
9/readme.md Outdated Show resolved Hide resolved
solutions.puml Show resolved Hide resolved
@CamiloTerevinto
Copy link
Contributor Author

Hey @PiotrJustyna, all comments solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illustrate timers.
2 participants