Fix unexpected interactions of text tool #1176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc8914b.
…ePrimaryColorChanged if State is NotFinalized
|
Thanks for looking at this! finalize_issue.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1097
Moved the color objects used for drawing text to the CurrentTextEngine and then only updating those colors when the color palette changes while the text tool is selected.
Removed FinalizeText on surface cloning. This seems to be the code that caused finalizations of text when using another tool. The text seems to finalize properly now, but I am not completely sure why the code was there to begin with, so this might have subtly broke something.