Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block break quests doesn't work #2246

Closed
StKillReal opened this issue Jul 5, 2024 · 8 comments
Closed

Block break quests doesn't work #2246

StKillReal opened this issue Jul 5, 2024 · 8 comments
Labels

Comments

@StKillReal
Copy link

What is your Quests version / build number (do not say "latest")?

image

Describe the problem and how to replicate it.

I have a quest in which I should break 36 blocks, but when I break it, it still shows 1/36
2024-07-05_20 25 35
2024-07-05_20 25 41

Any console errors to share?

No

If applicable, can you provide an example quest from quests.yml?

custom11:
    name: Вечер в хату
    ask-message: Так, нужно найти того человека и узнать у него информацию, после
      чего выкопать уголь и выйти на свободу...
    finish-message: С тюрьмой покончено, осталось поговорить с незнакомцем
    stages:
      ordered:
        '1':
          locations-to-reach:
          - world -5911.0 4.0 -611.0
          reach-location-radii:
          - 20
          reach-location-names:
          - Карьер
          complete-message: Вот он, нужно с ним поговорить на счет того незнакомца
        '2':
          npc-uuids-to-talk-to:
          - 53faa063-6046-4c06-971d-98ae7dcc5256
          complete-message: Привет, какими судьбами тут? Оу, тебя прислал наш общий
            знакомый.. Ладно, слушай, весь товар я успел спрятать. Скажи ему, чтобы
            искал в том ангаре, где мы передвали нашу 8 партию алмазов несколько лет
            назад. Притащи мне 4 угольных блока и я договорюсь за тебя.
        '3':
          break-block-names:
          - COAL_ORE
          break-block-amounts:
          - 36
          break-block-durability:
          - 0
          start-message: Так, еду и кирку я видел на выходе из казарм.
          complete-message: Фух, с этим все
        '4':
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 3953
            type: COAL_BLOCK
            amount: 4
          complete-message: Теперь нужно отнести их тому заключенному маяком.
        '5':
          items-to-deliver:
          - ==: org.bukkit.inventory.ItemStack
            v: 3953
            type: COAL_BLOCK
            amount: 4
          npc-delivery-uuids:
          - 53faa063-6046-4c06-971d-98ae7dcc5256
          delivery-messages:
          - Я не смогу помочь, если ты не доставишь мне 4 блока угля!
          complete-message: Отлично, я договорюсь за тебя. Иди к выходу, там тебя
            выпустят без лишних вопросов.
        '6':
          locations-to-reach:
          - world -5893.0 65.0 -826.0
          reach-location-radii:
          - 8
          reach-location-names:
          - Центральный вход в тюрьму
@StKillReal StKillReal added the bug label Jul 5, 2024
@Fanolcie
Copy link

Fanolcie commented Jul 6, 2024

Same problem

@PikaMug
Copy link
Owner

PikaMug commented Jul 6, 2024

@StKillReal @Fanolcie Can I get your /version output, please? I wasn't able to replicate this; the quest starts at 0/36 and increments to 1/36, 2/36, and so on using build 484.

@StKillReal
Copy link
Author

@PikaMug
image

@Fanolcie
Copy link

Fanolcie commented Jul 6, 2024

image

Quests 5.0.5

@Fanolcie

This comment was marked as off-topic.

@PikaMug
Copy link
Owner

PikaMug commented Jul 8, 2024

@StKillReal @Fanolcie Thanks for that information. It looks like there's going to be more work involved for these new Paper(+forks) builds. What I've done is attempt a workaround for break objectives. I'd appreciate your feedback after trying it:
https://ci.codemc.io/job/PikaMug/job/Quests/485/

Note that other block/item objectives are not yet fixed. I'll get to those after I hear back from you.

@Fanolcie
Copy link

Fanolcie commented Jul 8, 2024

It seems to be working now. I will test and report any errors. I appreciate for your work!

@PikaMug
Copy link
Owner

PikaMug commented Jul 12, 2024

I've applied the fix to all block and item objectives (including NPC delivery). This build has not been tested! Should you encounter any problems, please open a new issue.
https://ci.codemc.io/job/PikaMug/job/Quests/486/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants