Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save filees won't load correctly #73

Open
Pigable08 opened this issue Dec 2, 2024 · 6 comments
Open

Save filees won't load correctly #73

Pigable08 opened this issue Dec 2, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Pigable08
Copy link

Describe the bug
When you load a save file, the text below the "Import Save" button says it has imported, but nothing changed.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app
  2. Click "Import Save"
  3. Import any .w2bzip
  4. Nothing happens

Expected behavior
I expected the save file to load my save and all my elements/objects.

Screenshots
image
Note how the save says it has imported

Desktop (please complete the following information):

  • OS: Windows 11, (tried on Windows 10 as well)
  • Version 0.3.3
  • Iris XE Integrated Graphics
@Pigable08 Pigable08 added the bug Something isn't working label Dec 2, 2024
@Picorims
Copy link
Owner

Picorims commented Dec 3, 2024

Mmh that's annoying if that is the case.

Do you see an error in the logs? Did you try with a non empty save just to be sure? Are you sure you saved your changes?

Is it an installed version or a portable version?

@Pigable08
Copy link
Author

Pigable08 commented Dec 9, 2024

Sorry for late reply,

I originally had a weird copy of program files onto a USB but then found out the portable installation was a thing so I re-installed it that way onto my USB so its a clean, original install.
I've dug in the logs and it reads the file fine:

[2024-12-09T18:44:39.924] [DEBUG] main - reading D:\Wav2Bar\resources\app/temp/current_save/data.json...
[2024-12-09T18:44:39.925] [DEBUG] main - reading D:\Wav2Bar\resources\app/temp/current_save/data.json done.
[2024-12-09T18:44:39.925] [ERROR] main - could not read D:\Wav2Bar\resources\app/temp/current_save/data.json: SyntaxError: Unexpected end of JSON input

However, when it goes to read the JSON file, I've checked and it's completely empty.

I have tried to open another file and that works. Specifically, the app freezes then loads it.

[2024-12-09T18:50:20.240] [INFO] main - loading save file at d:\Music Visualisations\Template\Visualiser Template.w2bzip
[2024-12-09T18:50:20.330] [DEBUG] main - wrote json file to D:\Wav2Bar\resources\app/temp/current_save/data.json.
[2024-12-09T18:50:38.187] [INFO] main_renderer - reading the save...
[2024-12-09T18:50:38.187] [DEBUG] main - reading D:\Wav2Bar\resources\app/temp/current_save/data.json...
[2024-12-09T18:50:38.189] [DEBUG] main - reading D:\Wav2Bar\resources\app/temp/current_save/data.json done.
[2024-12-09T18:50:38.191] [INFO] main_renderer - applying save...

As you can see, it loads it perfectly and the .json file is read successfully, it's contents:
"
{"save_version":4,"software_version_used":"0.3.3-beta","software_version_first_created":"0.3.3-beta","screen":{"width":1980,"height":1080},"fps":60,"audio_filename":"Purple Final ver 2.0.wav","objects":{"43544f33-4359-43fc-a0e6-932b7aa012c9":{"name":"Waveform","layer":1,"coordinates":{"x":0,"y":980},"size":{"width":1980,"height":100},"rotation":0,"svg_filter":"","visualizer_points_count":200,"visualizer_analyzer_range":[0,750],"visualization_smoothing_type":"average","visualization_smoothing_factor":0.7,"color":"#7300ff","visual_object_type":"visualizer_straight_wave"},"eeec1bc2-c2ee-40d9-85f7-259ed5b1f0ba":{"name":"Particles","layer":0,"coordinates":{"x":0,"y":0},"size":{"width":1980,"height":1080},"rotation":0,"svg_filter":" <feColorMatrix in="SourceGraphic" type="luminanceToAlpha" result="LUMINANCE"> <feDiffuseLighting in="LUMINANCE" surfaceScale="10" result="LIGHTING"> <feDistantLight azimuth="90" elevation="28" result="1b729dc3-f97f-4abb-a5a0-397ae9ae7d68"> <feComposite in="LIGHTING" in2="SourceGraphic" operator="in" result="cef2867f-cd0f-433a-9948-2f0bf4a12a75">","visual_object_type":"particle_flow","particle_radius_range":[1,10],"flow_type":"radial","flow_center":{"x":990,"y":540},"flow_direction":0,"particle_spawn_probability":1,"particle_spawn_tests":1,"color":"#d4ff00"},"b99f8841-e72a-4a90-be47-1f041182f5e9":{"name":"Title","layer":0,"coordinates":{"x":25,"y":0},"size":{"width":1980,"height":100},"rotation":0,"svg_filter":"","visual_object_type":"text","text_type":"any","text_content":"Title (adjust bar to length of name ~26 pixels per character)","font_size":50,"color":"#ffffff","text_decoration":{"italic":false,"bold":false,"underline":false,"overline":false,"line_through":false},"text_align":{"horizontal":"left","vertical":"top"},"text_shadow":""},"666907d6-940e-423e-8b8a-e986744b1e2b":{"name":"Bar","layer":3,"coordinates":{"x":25,"y":60},"size":{"width":160,"height":10},"rotation":0,"svg_filter":"","color":"#ffffff","border_thickness":0,"border_radius":"","box_shadow":"","visual_object_type":"timer_straight_bar","timer_inner_spacing":2},"ecab063f-2083-46e5-8b22-8d4aebf88339":{"name":"Artist Name","layer":0,"coordinates":{"x":25,"y":75},"size":{"width":400,"height":100},"rotation":0,"svg_filter":"","visual_object_type":"text","text_type":"any","text_content":"NexoTek","font_size":25,"color":"#ffffff","text_decoration":{"italic":false,"bold":false,"underline":false,"overline":false,"line_through":false},"text_align":{"horizontal":"left","vertical":"top"},"text_shadow":""},"16a2e540-6478-4444-b76d-552aa32f6b7b":{"name":"Logo","layer":0,"coordinates":{"x":786,"y":430},"size":{"width":400,"height":400},"rotation":0,"svg_filter":"","visual_object_type":"shape","border_radius":"","box_shadow":"","background":{"type":"image","last_color":"#74410a","last_gradient":"linear-gradient(90deg, rgba(0,0,0,1) 0%, rgba(255,255,255,1) 100%)","last_image":"image.png","size":"contain","repeat":"no-repeat"}},"1df16a0b-0d9d-40d3-bbd8-376f49cecfd4":{"name":"Circle","layer":0,"coordinates":{"x":0,"y":0},"size":{"width":1980,"height":1080},"rotation":0,"svg_filter":"","visualizer_points_count":2,"visualizer_analyzer_range":[0,750],"visualization_smoothing_type":"average","visualization_smoothing_factor":0.7,"color":"#7300ff","border_radius":"","box_shadow":"","visualizer_bar_thickness":2,"visual_object_type":"visualizer_circular_bar","visualizer-radius":75}}}
"

NOTE: It might be because I am missing some files originally there.

@Picorims
Copy link
Owner

Picorims commented Dec 9, 2024

The save is a zip file so you can change the extension and check the JSON data inside by yourself. But if the JSON file is empty then something went wrong at saving. If you do this on the problematic save, do you find something in it?

@Pigable08
Copy link
Author

No, I checked while it was loaded. However, on my saves now, loading works fine. It might just be that one. One reason could be the fact I created the save on a school computer. These has limitations and we don't have admin. Could that cause it?

@Picorims
Copy link
Owner

If it tried to write a file and the computer denied it, that's perfectly possible that it didn't save. But I am deeply annoyed that it didn't warn you...

@Pigable08
Copy link
Author

Thanks. Saves work with new files though so it could be perms. Hopefully the conclusion has been reached. Any more info you need just shout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants