Reduce calculation in strategy functions #753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your clang format seems to be buggy, the original documentation formatting was correct. Use |
rwlee
commented
Jan 20, 2023
photon-lib/src/main/java/org/photonvision/PhotonPoseEstimator.java
Outdated
Show resolved
Hide resolved
photon-lib/src/main/java/org/photonvision/PhotonPoseEstimator.java
Outdated
Show resolved
Hide resolved
rwlee
commented
Jan 20, 2023
photon-lib/src/main/native/cpp/photonlib/RobotPoseEstimator.cpp
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Oct 15, 2023
Comment on lines
-488
to
+489
| if (alternateTransformDelta < smallestHeightDifference) { | ||
| if (alternateTransformDelta < smallestHeightDifference | ||
| && alternateTransformDelta < bestTransformDelta) { |
There was a problem hiding this comment.
So the point of this function is to find a transform such that the Z difference is minimized right? I think we can better represent this intent with something similar to (but not necessarily a) list comprehension? Probably out of scope, and I don't think anyone uses this function anyways.
mcm001
approved these changes
Oct 15, 2023
|
Waiting on code update so it builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few optimizations in the strategy logic and lots of formatting from clang format