-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5 digit team numbers #1474
Comments
Is this limitation in the UI or somewhere in backend code? |
I'm looking through the backend. It checks that the team number is an integer and if it is, it passes it to NetworkTableInstance.setServerTeam() from ntcore-java-2024.3.2, which passes the number to NetworkTablesJNI.setServerTeam(). I don't see why this code wouldn't work for 5-digit team numbers. Is it possible that we need to update ntcore to 2025 and 5-digit teams will work? |
Then my guess is just a UI limitation |
Why don't you think it's an ntcore 2024.3.2 limitation? Did WPILib support 5 digit team numbers in 2024? |
I'm not sure if they supported 5-digit teams but it doesn't matter. At some point we will have to update to 2025 and we will get those changes. But the main thing it looks like is a UI limitation checking for team numbers up to 9999 |
Yeah, someone just needs to go update the regex (or rewrite it as a lambda lol) |
ill put this in with the 2025 stuff tonight |
Allow 5 digit team numbers.
The text was updated successfully, but these errors were encountered: