Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 digit team numbers #1474

Closed
Juniormunk opened this issue Oct 18, 2024 · 7 comments · Fixed by #1484
Closed

5 digit team numbers #1474

Juniormunk opened this issue Oct 18, 2024 · 7 comments · Fixed by #1484
Labels
bug Something isn't working

Comments

@Juniormunk
Copy link
Contributor

Allow 5 digit team numbers.

@Juniormunk Juniormunk added the bug Something isn't working label Oct 18, 2024
@mcm001
Copy link
Contributor

mcm001 commented Oct 18, 2024

Is this limitation in the UI or somewhere in backend code?

@crschardt
Copy link
Contributor

crschardt commented Oct 19, 2024

I'm looking through the backend. It checks that the team number is an integer and if it is, it passes it to NetworkTableInstance.setServerTeam() from ntcore-java-2024.3.2, which passes the number to NetworkTablesJNI.setServerTeam(). I don't see why this code wouldn't work for 5-digit team numbers. Is it possible that we need to update ntcore to 2025 and 5-digit teams will work?

@Juniormunk
Copy link
Contributor Author

Then my guess is just a UI limitation

@crschardt
Copy link
Contributor

Why don't you think it's an ntcore 2024.3.2 limitation? Did WPILib support 5 digit team numbers in 2024?

@Juniormunk
Copy link
Contributor Author

I'm not sure if they supported 5-digit teams but it doesn't matter. At some point we will have to update to 2025 and we will get those changes. But the main thing it looks like is a UI limitation checking for team numbers up to 9999

@mcm001
Copy link
Contributor

mcm001 commented Oct 21, 2024

Yeah, someone just needs to go update the regex (or rewrite it as a lambda lol)

@Juniormunk
Copy link
Contributor Author

ill put this in with the 2025 stuff tonight

@srimanachanta srimanachanta linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants