From 24f94b656adb6c66d767d0cd0137bbaf32d7a9cf Mon Sep 17 00:00:00 2001 From: Drew Williams Date: Tue, 3 Sep 2024 19:18:47 -0400 Subject: [PATCH] formatting and javadoc --- .../USBCameras/ArduOV2311CameraSettables.java | 3 +++ .../ArduOV2311WindowsCameraSettables.java | 13 ++++++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311CameraSettables.java b/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311CameraSettables.java index 1f04948f07..70af64f4bb 100644 --- a/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311CameraSettables.java +++ b/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311CameraSettables.java @@ -20,6 +20,9 @@ import edu.wpi.first.cscore.UsbCamera; import org.photonvision.common.configuration.CameraConfiguration; +/* + * This class holds the non-windows camera quirks for the Arducam OV2311. This version supports auto-exposure, while windows does not. + */ public class ArduOV2311CameraSettables extends GenericUSBCameraSettables { public ArduOV2311CameraSettables(CameraConfiguration configuration, UsbCamera camera) { super(configuration, camera); diff --git a/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311WindowsCameraSettables.java b/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311WindowsCameraSettables.java index 3272c90f6f..51cfd6ba51 100644 --- a/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311WindowsCameraSettables.java +++ b/photon-core/src/main/java/org/photonvision/vision/camera/USBCameras/ArduOV2311WindowsCameraSettables.java @@ -20,9 +20,11 @@ import edu.wpi.first.cscore.UsbCamera; import edu.wpi.first.cscore.VideoException; import edu.wpi.first.math.MathUtil; - import org.photonvision.common.configuration.CameraConfiguration; +/* + * This class holds the windows specific camera quirks for the Arducam ov2311. A windows version is needed because windows doesn't expose the auto exposure properties of the arducam. + */ public class ArduOV2311WindowsCameraSettables extends GenericUSBCameraSettables { public ArduOV2311WindowsCameraSettables(CameraConfiguration configuration, UsbCamera camera) { super(configuration, camera); @@ -30,8 +32,13 @@ public ArduOV2311WindowsCameraSettables(CameraConfiguration configuration, UsbCa @Override protected void setUpExposureProperties() { - var expProp = findProperty( - "raw_exposure_absolute", "raw_exposure_time_absolute", "exposure", "raw_Exposure", "Exposure"); + var expProp = + findProperty( + "raw_exposure_absolute", + "raw_exposure_time_absolute", + "exposure", + "raw_Exposure", + "Exposure"); exposureAbsProp = expProp.get(); autoExposureProp = null;