Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs <0x0d> on the end of some digipeated packets #35

Open
PhirePhly opened this issue Nov 15, 2016 · 1 comment
Open

Logs <0x0d> on the end of some digipeated packets #35

PhirePhly opened this issue Nov 15, 2016 · 1 comment
Labels

Comments

@PhirePhly
Copy link
Owner

Many packets getting digipeated are logged with a carriage return at the end. Hopefully this isn't also getting appended to the transmitted packets.

2016-11-13 15:03:21.017 BALDI     R W7COA-9>TXQXPP,WIDE1-1,WIDE2-1:`2E!l!Aj/`"4l}_"
2016-11-13 15:03:21.018 VBALDI    T W7COA-9>TXQXPP,VBALDI*,WIDE2-1:`2E!l!Aj/`"4l}_"<0x0d>
@PhirePhly PhirePhly added the bug label Nov 15, 2016
@PhirePhly
Copy link
Owner Author

It looks like these are actually coming in on the Rx, and being preserved as the packet is being processed. They aren't showing up on the R logs since it uses a DIFFERENT TNC2 formatter than the T side:

aprx/ax25.c

Lines 242 to 256 in d3e006f

for (; s < e; ++s) {
if (*s == '\n') /* Stop at first LF */
break;
*t++ = *s;
}
*t = 0;
/* Chop off possible immediately trailing CR characters */
for ( ;t > tnc2buf; --t ) {
int c = t[-1];
if (c != '\r') {
break;
}
t[-1] = 0;
}

This issue seems to be specific to the BALDI station or the local network...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant