Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static knockout scheduler should validate the schedule upfront #6

Open
PeterJCLaw opened this issue Apr 24, 2021 · 0 comments · May be fixed by #36
Open

Static knockout scheduler should validate the schedule upfront #6

PeterJCLaw opened this issue Apr 24, 2021 · 0 comments · May be fixed by #36

Comments

@PeterJCLaw
Copy link
Owner

PeterJCLaw commented Apr 24, 2021

Specifically there are various bad input states which aren't detected until trying to actually populate the matches -- i.e: after the leagues have all run.

Known scenarios:

  • if you add a reference to a match that doesn't exist (e.g: '500' with only three rounds)
  • if you add a reference to a seed which doesn't exist (e.g: S30 with only 25 teams)
  • if you put the wrong number of teams in a match

Related to this there are no warnings for omitted seed values. This will need to be a warning (perhaps via the compstate validation logic rather than input validation) as it is legitimate to miss off the bottom seeds. Likely we don't want to miss seeds from the middle of the list though.

PeterJCLaw added a commit that referenced this issue Nov 17, 2024
This ensures that any errors in defining a static knockout are caught
when the file is first parsed, rather than only once the league stage
has completed.

Fixes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant