Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a mechanism to turn off shepherds & layout #25

Open
PeterJCLaw opened this issue Aug 8, 2023 · 2 comments
Open

Have a mechanism to turn off shepherds & layout #25

PeterJCLaw opened this issue Aug 8, 2023 · 2 comments

Comments

@PeterJCLaw
Copy link
Owner

PeterJCLaw commented Aug 8, 2023 •
edited
Loading

Sometimes we don't want to deploy shepherds, so needing to include them in the compstate isn't ideal.
While the core library seems ok with some aspects of shepherds being missing, it's inconsistent about how much is needed.

Additionally SRComp-HTTP requires that:

  • the signal_shepherds key is provided, though the core library does not (fixed in PeterJCLaw/srcomp-http@3ad10e8)
  • that teams have locations (which relates to their shepherding assignments)
PeterJCLaw added a commit to PeterJCLaw/srcomp-http that referenced this issue Aug 8, 2023
@PeterJCLaw
Support a lack of shepherding signals
1e3376c 
This is allowed by the core srcomp library, so the HTTP API should
not complain about it being missing.

See also PeterJCLaw/srcomp#25
@PeterJCLaw
Copy link
Owner Author

Note that while some partial shepherd/layout data combinations result in various loading errors, others appear to load ok.

PeterJCLaw added a commit to sourcebots/compstate-smallpeice2023 that referenced this issue Aug 8, 2023
@PeterJCLaw
Add shepherding data which it turns out is needed
ad1a05e 
See PeterJCLaw/srcomp#25
@PeterJCLaw
Copy link
Owner Author

This might be something to turn into a warning and then silence via a warnings silencing mechanism? (#23)

Or we might want to just drop this entirely as we're not using it any more.

@PeterJCLaw PeterJCLaw changed the title Have a mechanism to turn off shepherds Have a mechanism to turn off shepherds & layout Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PeterJCLaw