Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Make Properties window respect dark theme #76

Open
kristoferblack opened this issue Nov 21, 2024 · 4 comments
Open

Request: Make Properties window respect dark theme #76

kristoferblack opened this issue Nov 21, 2024 · 4 comments

Comments

@kristoferblack
Copy link

The properties window which is almost always open/being used currently does not go into dark mode, while the rest of the interface does. Since this is such a frequently used window, it'd be great if that could be added. The only other window having a remainder of light mode is the Layers window but I think I understand there are some limitations to what can be done there. Thanks!

image

@yak3d
Copy link
Contributor

yak3d commented Nov 21, 2024

I can look at this.

@yak3d
Copy link
Contributor

yak3d commented Nov 25, 2024

It looks like we're missing the UITheme class for PropertyGrid. @Perchik71 this is one of the WinForms windows embedded in a Qt window. I assume though if I add the PropertyGrid class and instantiate it in UIThemePatch it should still work? The Material Palette is also an embedded WinForm and seems to style okay.

@Perchik71
Copy link
Owner

Perchik71 commented Nov 25, 2024

@yak3d Yes, you correctly noticed that this is a PropertyGrid, I do not know how to color it.
First, need to determine exactly what this window is PropertyGrid, perhaps there is a hint in GetClassName().
Visit PropertyGrid-Made-Easy it is colored by the WM_NOTIFY message, maybe need OWNERDRAW style.

Edit (excerpt from the article):
Owner Draw Tip
Most of the look and feel of the grid is achieved by owner drawing a Listbox. One mistake that I have seen developers make when owner drawing something is not making use of the stock objects (pens and brushes) and system colors. The following is an example of how NOT to draw your control.

@yak3d
Copy link
Contributor

yak3d commented Nov 25, 2024

Thanks for the tips, I'll look into it. Never done this type of stuff before but I'll take a crack at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants