Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV-1778: Fix PII consent dialog #12

Open
wants to merge 1 commit into
base: pearson-release/olive.main
Choose a base branch
from

Conversation

kuipumu
Copy link

@kuipumu kuipumu commented Oct 17, 2024

Tickets

Description

This PR adds a fix to the LTI Consumer XBlock PII consent dialog. Currently after the user clicks on the "Ok" or "Cancel" button of the PII consent dialog, a h1 element with the text "Confirm Dialog Result: Yes" or "Confirm Dialog Result: Yes" is added to the body element, this element shouldn't be visible since it's only use to resolve a promise after the button is clicked.

Type of Change

  • Hide element created after PII consent dialog is confirmed or cancelled.

Testing:

  1. Make sure the edx-platform version used has this commit: Pearson-Advance/edx-platform@44d1c52
  2. Add a global status message to the LMS: https://localhost:18000/admin/status/globalstatusmessage/
  3. Install and configure xblock-lti-consumer
  4. Enable PII on the course you would use for testing: https://localhost:18000/admin/lti_consumer/courseallowpiisharinginltiflag/
  5. Add a LTI 1.1 or 1.3 Consumer XBlock to the course.
  6. Set "Request user's username" or "Request user's email" to True on the LTI Consumer XBlock.
  7. Go to the course and try to execute the LTI launch.
  8. Click on the "Ok" or "Cancel" button of the PII consent dialog.
  9. There should not be any "Confirm Dialog Result: Yes" or "Confirm Dialog Result: Yes" element.

@kuipumu kuipumu self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant