Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV 888 - Sidebar styling fixes #7

Merged
merged 1 commit into from
Dec 5, 2023
Merged

PADV 888 - Sidebar styling fixes #7

merged 1 commit into from
Dec 5, 2023

Conversation

alexjmpb
Copy link
Contributor

@alexjmpb alexjmpb commented Dec 4, 2023

Description:

This PR aims to fix various styles in the sidebar navigation that may affect the user experience.

Changes Made

  • Align text to left inside sequence text.
  • Improve loading screen.
  • Improve error screen.

Screenshots

Text align

Before

Screenshot from 2023-12-04 12-27-03

After

Screenshot from 2023-12-04 12-26-22

Loading screen

Before

Screenshot from 2023-12-04 12-27-10

After

Screenshot from 2023-12-04 12-28-39

Error message

Before

Screenshot from 2023-12-04 12-27-35

After

Screenshot from 2023-12-04 12-28-54

Reviewers:

src/index.scss Outdated Show resolved Hide resolved
Copy link

@Jacatove Jacatove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spinner is far better than the "Loading" text but I wonder if it is not a big effort use the spinner here
image
and only open the sidebar when it has its content?. This is just an observation. What are your thought?.

@alexjmpb
Copy link
Contributor Author

alexjmpb commented Dec 5, 2023

The spinner is far better than the "Loading" text but I wonder if it is not a big effort use the spinner here image and only open the sidebar when it has its content?. This is just an observation. What are your thought?.

The problem is that in this case we would have to change the learning MFE, since the button belongs there. I was thinking to do this when adding the disable sidebar functionality.

@alexjmpb alexjmpb merged commit 7da8ab4 into master Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants