Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include development Gemma in the CI build matrix #22

Open
1 of 3 tasks
arteymix opened this issue May 21, 2022 · 4 comments
Open
1 of 3 tasks

Include development Gemma in the CI build matrix #22

arteymix opened this issue May 21, 2022 · 4 comments
Assignees

Comments

@arteymix
Copy link
Member

arteymix commented May 21, 2022

To ensure that Gemma.R is always working with upcoming features and improvements, it would be critical to include the development instance in its CI.

  • whitelist GitHub Actions IP in the Apache configuration @dima-v-v
  • add a different Gemma hostname to the build matrix @oganm
  • trigger a build when Gemma development branch is deployed using some POST hook

The IP for GitHub Actions can be found in the docs. I'm on mobile now, so it's not exactly convenient to pull that information.

@oganm
Copy link
Member

oganm commented May 25, 2022

Workflow in the dev_test_workflow branch has a job pointing to the dev.gemma.msl now. currently this fails since actions machines aren't allowed to reach there yet.

@arteymix
Copy link
Member Author

Good. I'll follow up with dima to get the IP ranges allowed.

@arteymix
Copy link
Member Author

I sent this file to dima which contains all the Apache directives to allow GitHub Actions access to dev.gemma.msl.ubc.ca: github-actions.conf.txt.

@oganm
Copy link
Member

oganm commented Sep 17, 2022

Added the dev testing to the current branch but it's not currently working. Will poke dima again

A current version the file above can be generated by doing

gh::gh('/meta')$actions %>% unlist %>% paste('Require ip',.) %>% cat(file = 'file.txt',sep='\n')

github-actions.conf.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants