Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for advice about merging match_keypoints into hloc sfm pipeline #92

Open
DabblerGISer opened this issue Dec 23, 2024 · 3 comments
Open

Comments

@DabblerGISer
Copy link

I've tried using superpoint and also dedode as keypoints extractor and then match with RoMa but can't get a proper result. How could I improve the result?
The basic idea is that I firstly extract all keypoints and then normalize the keypoints into range [-1, 1].

def to_reference_coord(kpt, W, H):
kpts = torch.stack((kpt[..., 0]/(W/2) -1, kpt[..., 1]/(H/2) -1), axis=-1)
return kpts

And then using roma model to calculate the warp and certainty. then using kpts, warp and certainty as input of match_keypoints. After getting the results I also used ransac to filter some of the matches.

I'm not able to reconstruct the model correctly by this way.
2024-12-23 13-45-05 的屏幕截图
Thus I check the visual result of matches:
0001 png_0022 png
0022 png_0026 png

Anybody could give me some advice to improve the pipeline? Thanks!

@DabblerGISer
Copy link
Author

By the way, this magic pickup truck is really hard to reconstruct. LOL

@Parskatt
Copy link
Owner

I would avoid matching when the roma confidence is very low. In the provided images I would guess that is the case.

@DabblerGISer
Copy link
Author

I would avoid matching when the roma confidence is very low. In the provided images I would guess that is the case.

Actually RoMa reaches pretty accurate result by RegressionMatcher.match. Thank you for your reply, I will firstly have a review on my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants