Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent update greatly increased GPU memory usage #21

Open
ducha-aiki opened this issue Feb 7, 2024 · 2 comments
Open

Recent update greatly increased GPU memory usage #21

ducha-aiki opened this issue Feb 7, 2024 · 2 comments

Comments

@ducha-aiki
Copy link

ducha-aiki commented Feb 7, 2024

Matching 2 images with 20000 matches works with commit 69cefb1
and doesn't with currentmain.

I guess that is because of removing

    torch.backends.cuda.matmul.allow_tf32 = True # allow tf32 on matmul TODO: these probably ruin stuff, should be careful
    torch.backends.cudnn.allow_tf32 = True # allow tf32 on cudnn
@Parskatt
Copy link
Owner

Parskatt commented Feb 7, 2024

I think it's rather due to the implementation of the KDE which is naive: https://github.com/Parskatt/RoMa/blob/main/roma/utils/kde.py

20k matches from the KDE requires starting from 80k and then resampling down to 20k.

@Parskatt
Copy link
Owner

Parskatt commented Feb 7, 2024

#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants