Enable to use a BottomNavigator scoped to a Fragment and tied to its child FragmentManager #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…child FragmentManager
guelo
suggested changes
May 1, 2021
There was a problem hiding this comment.
Thank you so much for your submission! I think the code looks good but in order to merge I need 3 things.
- Unit tests for the new
onCreatefunctions. You should be able to copy similar tests in BottomNavigationTest. - A demo in the sample app that exercises the child fragments. Maybe one of the existing tabs could have a nested BottomNavigator? The sample app is used both as a demo and a platform for espresso tests. A simple espresso test is fine, it doesn't have to be comprehensive.
- Some documentation about this in README.md
Is this work that you can do?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've added the ability of properly using a
BottomNavigatorinside aFragmentinstead of anActivity. It implies to execute transactions with theFragment's childFragmentManager, tie the execution of commands to its lifecycle and scope theBottomNavigatorinstance to itsViewModelStore.For the sake of simplicity and backward compatibility, I've overloaded a few methods with alternatives that take a
Fragmentin argument.This PR would fix #13.