Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Surfaceless VTOL Quad Tailsitters Documentational Error #1897

Open
aoberai opened this issue May 30, 2022 · 8 comments
Open

Control Surfaceless VTOL Quad Tailsitters Documentational Error #1897

aoberai opened this issue May 30, 2022 · 8 comments

Comments

@aoberai
Copy link

aoberai commented May 30, 2022

https://docs.px4.io/master/en/frames_vtol/tailsitter.html

This page suggests that VTOL Quad Tailsitters without elevons (control surfaceless) are supported by PX4 which is not true; pitch and roll differential thrust don't exist for control surfaceless vtol tailsitters with PX4. For the PX4, elevons are mandatory and the documentation should be updated to show this.

@hamishwillee
Copy link
Collaborator

Thanks @aoberai

@RomanBapst Can you confirm? The specific text here says "Four rotor VTOL with optional elevons. Uses rotors to transition between modes (along with elevons if present)., which was my understanding.

How would you reword?

@hamishwillee
Copy link
Collaborator

Or @sfuhrer Might you be able to comment?

@sfuhrer
Copy link
Contributor

sfuhrer commented Jun 2, 2022

Maybe "Four rotor VTOL with elevons for pitch/roll control in cruise flight. Uses rotors along with elevons to transition between modes."

@sfuhrer
Copy link
Contributor

sfuhrer commented Jun 2, 2022

Once we have made the small code adjustments to support elevon-less flights and tested it we can revert to the previous version.

@aoberai
Copy link
Author

aoberai commented Jun 2, 2022

Do you know what the timeline on "small code adjustments to support elevon-less flights and tested it we can revert to the previous version" would be? I would be happy to pr it in if people are busy, do you have any advice on where to look?

@sfuhrer
Copy link
Contributor

sfuhrer commented Jun 2, 2022

Do you know what the timeline on "small code adjustments to support elevon-less flights and tested it we can revert to the previous version" would be? I would be happy to pr it in if people are busy, do you have any advice on where to look?

I would have said a couple of weeks. This branch gives you some ideas of what the changes are about, though it's not in a flyable state I think https://github.com/PX4/PX4-Autopilot/commits/quad-tailsitter-no-surfaces-testing

@tstastny
Copy link

tstastny commented Jun 8, 2022

@aoberai The minimal patch for this would be something like:

  1. start from here https://github.com/PX4/PX4-Autopilot/commits/quad-tailsitter-no-surfaces-testing as @sfuhrer mentioned
  2. revert the last commit there -- this was a specific hard coded mixer change for a particular airframe's mixer
  3. additionally add in a scaler for the pitch and roll differential thrusts, as is done with the parameter param_vt_fw_difthr_sc for the yaw axis already

Would be great if you could take a stab at a PR @aoberai -- I likely wont have time to look at this for at least the next week, but @sfuhrer and I could give you pointers if you make the code changes.

@hamishwillee
Copy link
Collaborator

Thanks @sfuhrer (et al). Given you're actively looking at working on this I'd rather leave this open for a few weeks and see how it develops than update the docs :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants