Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

_gps_check_fail_status.flags.fix can never be true #699

Open
CarlOlsson opened this issue Jan 7, 2020 · 1 comment
Open

_gps_check_fail_status.flags.fix can never be true #699

CarlOlsson opened this issue Jan 7, 2020 · 1 comment

Comments

@CarlOlsson
Copy link
Contributor

This
https://github.com/PX4/ecl/blob/066392ef0247e010d8d10fb33fc6b5da21476227/EKF/gps_checks.cpp#L119-L119
Can never be true because collect_gps() only runs if fix_type > 2
https://github.com/PX4/ecl/blob/066392ef0247e010d8d10fb33fc6b5da21476227/EKF/estimator_interface.cpp#L214-L214

@priseborough
Copy link
Collaborator

For consistency with how we handle quality for other sensors, we should read in the GPS data regardless of quality and check if quality, eg fix type, meets minimum required for current use when it's popped from the buffer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants