ADSB: improve testability and small refactor #24127
Open
+83
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @asimopunov |
That enables us to time the unit tests better plus saves some flash and CPU. Signed-off-by: Silvan Fuhrer <[email protected]>
Saves some flash and CPU by not having to call hrt_absolute_time(). Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
MaEtUgR
force-pushed
the
pr-adsb-unit-test-improvements-main
branch
from
8f91771 to
5fcb72d
Compare
MaEtUgR
added
Admin: Cleanup (housekeeping) 🧹
and removed
Admin: Cleanup (housekeeping) 🧹
labels
MaEtUgR
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Some of the unit tests for ADSB failed in our fork of PX4. My best guess is that it has something to do with timing. I don't understand how it is working atm without passing the "current time" to the unit test when the ADSB functionality we're testing is depending on the exact timing of the incoming faked conflicts.
Solution
In unit tests define time of reception of new/removed conflict input.
Changelog Entry
For release notes: