We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I found many wrong type annotations in the codebase after a quick glance.
https://github.com/OmniSafeAI/safety-gymnasium/blob/c1c598ea45f23535405f9941695800bae41d3a4a/safety_gymnasium/utils/random_generator.py#L170-L173
-def constrain_placement(self, placement: dict, keepout: float) -> tuple[float]: +def constrain_placement(self, placement: list[float], keepout: float) -> tuple[float, float, float, float]:
Also, mypy reports:
mypy
-Found 129 errors in 13 files (checked 82 source files)
We should enable a CI workflow to check type annotations are correct.
Update type annotations and enable mypy in the CI workflow. And remove:
https://github.com/OmniSafeAI/safety-gymnasium/blob/c1c598ea45f23535405f9941695800bae41d3a4a/pyproject.toml#L150-L156
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Required prerequisites
Motivation
I found many wrong type annotations in the codebase after a quick glance.
https://github.com/OmniSafeAI/safety-gymnasium/blob/c1c598ea45f23535405f9941695800bae41d3a4a/safety_gymnasium/utils/random_generator.py#L170-L173
Also,
mypy
reports:-Found 129 errors in 13 files (checked 82 source files)
We should enable a CI workflow to check type annotations are correct.
Solution
Update type annotations and enable
mypy
in the CI workflow. And remove:https://github.com/OmniSafeAI/safety-gymnasium/blob/c1c598ea45f23535405f9941695800bae41d3a4a/pyproject.toml#L150-L156
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: