-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when send h265 1280x720 ffplay video will block broken #77
Comments
Are you suggesting replacing this block with just packets.emplace(id,pkt); ? I agree this code is bad... as soon as we go out of scope, tmp_pkt gets freed... packets.emplace has to either copy or take ownership. Seems like maybe a shared_ptr approach would be good. |
fixed i put my patch here I fix a lot of it ps: |
Please learn about Pull Requests. (PR)s. It saves a lot of time and effort for everyone. |
i will try~~~~tks~ |
we found this problem, then saw this issue by today |
thank you man ~ hawuwu163 |
reason because memcpy(tmp_pkt.data.get(), pkt.data.get(), pkt.size); -> need time and make slow sendto
better be no copy, just copy data pointer
//in MediaSession::AddSource
tmp_pkt.data = pkt.data;
memcpy(tmp_pkt.data.get(), pkt.data.get(), pkt.size);
tmp_pkt.size = pkt.size;
tmp_pkt.last = pkt.last;
tmp_pkt.timestamp = pkt.timestamp;
tmp_pkt.type = pkt.type;
packets.emplace(id, tmp_pkt);
The text was updated successfully, but these errors were encountered: