Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hurlfmt check always returns non-zero exit code #2919

Open
jcamiel opened this issue Jun 13, 2024 Discussed in #2917 · 3 comments
Open

hurlfmt check always returns non-zero exit code #2919

jcamiel opened this issue Jun 13, 2024 Discussed in #2917 · 3 comments
Labels
bug Something isn't working

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented Jun 13, 2024

Discussed in #2917

Originally posted by azzamsa June 13, 2024
Hi, 👋🏽

I am using hurlfmt 4.3.0 and when running hurlfmt tests/api-collection/meta/health.hurl --check it always gives me non-zero exit status. However hurlfmt tests/api-collection/meta/health.hurl --in-place doesn't change or complain about anything.

POST {{base_url}}
Content-Type: application/json

```graphql
{
  health {
    status
  }
}
```

HTTP 200
[Asserts]
status == 200
jsonpath "$.data.health.status" == "running"
tin on  master [!] is 📦 v1.2.0 via 🦀 v1.78.0
🐡 ❯ hurlfmt tests/api-collection/meta/health.hurl --check

tin on  master [!] is 📦 v1.2.0 via 🦀 v1.78.0
🐡 ❯ echo $status
1

Am I missing something?

Thanks! 🍜

@jcamiel jcamiel added the bug Something isn't working label Jun 13, 2024
@azzamsa
Copy link
Contributor

azzamsa commented Jun 13, 2024

@jcamiel I will take this, I hope I can fix this, as I made a similar feature for my app.

Would you like to point out the lines that I need to play with?

@fabricereix
Copy link
Collaborator

Hi @azzamsa,
It might not be a good time to touch hurlfmt.
We plan to rewrite some parts to align its code with hurl.
We will look at your bug afterward.

@azzamsa
Copy link
Contributor

azzamsa commented Jun 13, 2024

Oh, I see.

Okay, In meantime, I will just remove hurlfmt --check from my CI.

Thank you for hurl. 🍨

azzamsa added a commit to azzamsa/tin that referenced this issue Jun 13, 2024
hurlfmt check always returns non-zero exit code
Orange-OpenSource/hurl#2919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants