Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto scroll to selected item with actions.navigateToDir(folderPath, filePath) #297

Open
c3wenjiaowang opened this issue Dec 22, 2020 · 4 comments

Comments

@c3wenjiaowang
Copy link

When we used navigateToDir with passing both paths for parent folder and the file entry, the navigator would update the current path to the folderPath, and has the according file entry highlighted. But if the folder has a long list of files, and this selected file is down at bottom of the list, the navigator pane is not scrolling to the selected entry, and user has to manually use mouse to scroll down the list. May I ask is there any way we can auto-scroll? Thanks!

@visortelle
Copy link
Contributor

Hi, @c3wenjiaowang. This feature is not implemented.

@c3wenjiaowang
Copy link
Author

@visortelle Thanks! I have tried to add the feature in the source code, and it works with that change. May I ask can you add me as a contributor, so that I can submit a PR, and have it added to the library if possible? Thanks a lot!

@visortelle
Copy link
Contributor

@c3wenjiaowang I don't know. I'm not a maintainer of this repo. :)

@c3wenjiaowang
Copy link
Author

I created a PR for resolving this issue, but can't add a reviewer on the PR. Could anyone help to review the PR: #299? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants