Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update All fn Selector "Magic Values" Into Explicit fn Selector Calculation #419

Open
1 task done
0xNeshi opened this issue Nov 25, 2024 · 0 comments
Open
1 task done
Assignees
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 1 We will do our best to deal with this. type: feature New feature request. type: ref A code update that doesn't meaningfully change functionality.

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Nov 25, 2024

What is the feature you would like to see?

Example

Turn this:

 const SINGLE_TRANSFER_FN_SELECTOR: FixedBytes<4> = fixed_bytes!("f23a6e61");

Into this:

const SINGLE_TRANSFER_FN_SELECTOR: [u8; 4] = function_selector!(
    "onERC1155Received",
    Address,
    Address,
    U256,
    U256,
    Bytes
);

Original comment that prompted this issue's creation: #417

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added priority: 1 We will do our best to deal with this. type: feature New feature request. good first issue Good for newcomers. effort: low Easy or tiny task that takes less than a day. type: ref A code update that doesn't meaningfully change functionality. labels Nov 25, 2024
@0xNeshi 0xNeshi added this to the Release v0.2.0 milestone Nov 25, 2024
@0xNeshi 0xNeshi self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 1 We will do our best to deal with this. type: feature New feature request. type: ref A code update that doesn't meaningfully change functionality.
Projects
Status: Todo
Development

No branches or pull requests

1 participant