Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add Benches for ERC1155 to the Report #413

Closed
1 task done
0xNeshi opened this issue Nov 20, 2024 · 0 comments
Closed
1 task done

[Feature]: Add Benches for ERC1155 to the Report #413

0xNeshi opened this issue Nov 20, 2024 · 0 comments
Assignees
@qalisander
Labels
effort: low Easy or tiny task that takes less than a day. priority: 1 We will do our best to deal with this. type: feature New feature request.

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Nov 20, 2024

What is the feature you would like to see?

The benches workflow fails when this is added to main.rs, see https://github.com/OpenZeppelin/rust-contracts-stylus/actions/runs/11930071646/job/33251438722?pr=412.

We should investigate why that is, fix it and add the benches to the main report.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added priority: 1 We will do our best to deal with this. type: feature New feature request. effort: low Easy or tiny task that takes less than a day. labels Nov 20, 2024
@0xNeshi 0xNeshi changed the title [Feature]: Add Benches for ERC1155 to Report [Feature]: Add Benches for ERC1155 to the Report Nov 21, 2024
@0xNeshi 0xNeshi mentioned this issue Nov 22, 2024
Merged
3 tasks
bidzyyys added a commit that referenced this issue Nov 28, 2024
@0xNeshi @bidzyyys @qalisander
feat: ERC1155Burnable extension (#417)
d0a4e57 
<!--
Thank you for your interest in contributing to OpenZeppelin!

Consider opening an issue for discussion prior to submitting a PR. New
features will be merged faster if they were first discussed and designed
with the team.

Describe the changes introduced in this pull request. Include any
context necessary for understanding the PR's purpose.
-->

<!-- Fill in with issue number -->
Resolves #362 #413

Built off of
[erc1155-burnable](https://github.com/OpenZeppelin/rust-contracts-stylus/tree/erc1155-burnable).
Due to major merge conflicts when trying to update the branch with
`main`, decided to create a new branch and manually copy/paste the
changes (commits
5e96f2c
and
b22707d).

For the changes to the original check out the commit messages.

#### PR Checklist

<!--
Before merging the pull request all of the following must be completed.
Feel free to submit a PR or Draft PR even if some items are pending.
Some of the items may not apply.
-->

- [x] Tests
- [x] Documentation
- [x] Changelog

---------

Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Alisander Qoshqosh <[email protected]>
@0xNeshi 0xNeshi closed this as completed Nov 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Rust Contracts Stylus Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qalisander qalisander

Labels
effort: low Easy or tiny task that takes less than a day. priority: 1 We will do our best to deal with this. type: feature New feature request.
Projects
Rust Contracts Stylus
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xNeshi @qalisander