Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink current naming convention in contracts #386

Open
1 task done
bidzyyys opened this issue Oct 30, 2024 · 0 comments
Open
1 task done

Rethink current naming convention in contracts #386

bidzyyys opened this issue Oct 30, 2024 · 0 comments
Labels
needs triage Needs to be assigned the appropriate labels priority: 0 Nice-to-have. Willing to ship without this. type: ref A code update that doesn't meaningfully change functionality.

Comments

@bidzyyys
Copy link
Collaborator

What is the feature you would like to see?

Right now we use in some cases Solidity like naming convention (_do_sth()). It is not recommended attitude in Rust and causes cargo clippy issues (right now disabled). We should rethink this topic and make sure our library is consistent in terms of naming.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@bidzyyys bidzyyys added priority: 0 Nice-to-have. Willing to ship without this. needs triage Needs to be assigned the appropriate labels type: ref A code update that doesn't meaningfully change functionality. labels Oct 30, 2024
@qalisander qalisander mentioned this issue Oct 31, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage Needs to be assigned the appropriate labels priority: 0 Nice-to-have. Willing to ship without this. type: ref A code update that doesn't meaningfully change functionality.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bidzyyys