Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect issues in parent initializer calls #160

Open
frangio opened this issue Sep 7, 2020 · 1 comment · May be fixed by #1095
Open

Detect issues in parent initializer calls #160

frangio opened this issue Sep 7, 2020 · 1 comment · May be fixed by #1095

Comments

@frangio
Copy link
Contributor

frangio commented Sep 7, 2020

From Slither's upgradeability checks.

We can try to detect issues with parent initializer calls, concretely whether they are 1) missing, 2) duplicate, or 3) incorrectly linearized.

The main question is how we detect what is an initializer function. We could look for an initializer modifier, or for functions with name initialize, or for the naming convention used by Contracts Ethereum Package (soon Contracts Upgrade Safe) which is something like __ContractName_init.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants