Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deployement using create2 without the Defender requirement #79

Open
Magicking opened this issue Oct 23, 2024 · 2 comments

Comments

@Magicking
Copy link

It's currently impossible to deploy using create2 without the assistance of the Defender; it's a bummer as it seems this could be a low-hanging fruit to support this by passing the salt arg and calling create2 below if there is a salt.

image

About Create2 https://docs.openzeppelin.com/cli/2.8/deploying-with-create2

@ericglau
Copy link
Member

Deploying with create2 requires a factory contract. It doesn't seem possible to just broadcast a create2 call directly from a script.

Using create2 with Defender is recommended because Defender keeps track of the factory addresses on each chain.

To support this request, we could consider one of the following:

@pavlovdog
Copy link

@Magicking, Hey, I ran into the same issue. Here's a little PoC on how you can do it yourself while keeping all other functionality.

https://github.com/pimlicolabs/magic-spend/blob/main/src/MagicSpendFactory.sol#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants