Refactor for latest Metamask changes #201
Conversation
…ethernaut into upgrade-to-latest-metamask
Co-authored-by: Francisco Giordano <[email protected]>
|
There are a couple of MetaMask deprecation notices in the console; not sure if it is in scope for this PR, so just mentioning in case helpful: Related: #188 |
Yes, apparently there's no way right now to get rid of them. They are given by the Web3. Apparently, because of backward compatibility, they decided to not remove them for the time being. You can read more about it here and here. You can still see them being used |
|
I deleted my last comment - apologies for the false notification - I switched off Rinkeby in the middle of testing and forgot to switch back. |
| @@ -47,14 +47,12 @@ window.addEventListener('load', async() => { | |||
| if (window.ethereum) { | |||
| window.web3 = new constants.Web3(window.ethereum) | |||
| try { | |||
| await window.ethereum.enable() | |||
| await window.ethereum.request({method: `eth_requestAccounts`}) | |||
There was a problem hiding this comment.
You should never initiate a connection request on page load.
Though, it should be address as a separate issue. Let's bring it back ASAP.
|
Thank you all for working on this and reviewing it! |
Co-authored-by: Dario <[email protected]> Co-authored-by: Francisco Giordano <[email protected]>
Resolves #198
Resolves #200
and partially #188