Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoubleEntryPoint Level can be solved with a bot that always raises alerts #655

Open
Drblessing opened this issue May 8, 2023 · 1 comment

Comments

@Drblessing
Copy link

The detection bot:

contract DetectionBot is IDetectionBot {
    IForta public forta; 
    constructor (IForta forta_) {
        forta = forta_;
    }
    function handleTransaction(address user, bytes calldata msgData) external {

        forta.raiseAlert(user);

        return;
    }
}

will auto raise alerts and effectively DDOS the delegateTransfer method. It passes as a valid solution to the level though.

@Nfire2103
Copy link

I noticed the same problem. So, I make a PR to fix this : #745. In this one, I updated DetectionBot solution to a real solution. I also updated validateInstance to prevent DetectionBot which always raises alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants