-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error messages for require statements #147
Comments
I agree that the format should be consistent with other OpenZeppelin contracts. Should we wait until #117 is done and then update or do it as part of that? I am keen to get the upgrade to Solidity 0.5 complete. |
I don't have good experience with require error messages on ropsten. How about you guys? |
I agree we have to wait for the update to Solidity 0.5, I was thinking about adding error messages during #177 but I didn't want to mix these issues. |
@paulinablaszk are there still requires without messages ? |
I think we should add error messages for all require (and assert) statements in contracts. What do you think about the format of reason strings? I think it should be consistent with other OpenZeppelin contracts
The text was updated successfully, but these errors were encountered: