Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo and weirdness in UNKNOWN_ACT0_DATA message #39

Open
matthijskooijman opened this issue Jun 24, 2024 · 1 comment
Open

Typo and weirdness in UNKNOWN_ACT0_DATA message #39

matthijskooijman opened this issue Jun 24, 2024 · 1 comment

Comments

@matthijskooijman
Copy link
Contributor

While building the 6.1.0 Debian package, the debian linting tools point out a possible typo in the binary ("thast" should be "that"). Looking in the compiled binary, I see:

$ strings /usr/bin/nforenum |grep thast
Unknown data does not allow processesing past thast this point.

Looks like two typos, also in processing, so that should be an easy fix.

However, looking for thast in the source does not return any results. It looks like the above string comes from this source line:

$ grep -r processesing .
./src/lang/message_english.h:NFO_MESSAGE(UNKNOWN_ACT0_DATA,"Unknown data does not allow processesing past this point.\n",USE_PREFIX|HAS_OFFSET)

So somehow the "this" in that line is replaced by "thast"? I had a quick look at the macros that generate these messages, but could not find any issue quickly, but I also did not dig deep. I do not have time to dig further right now, but I wanted to record this somewhere.

Maybe someone with a local grfcodec build can check if they see the same weirdness in the compiled binary?

@LordAro
Copy link
Member

LordAro commented Jun 24, 2024

I can't find thast with a fresh checkout (of master) & build

$ strings build/nforenum | grep thast
$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants