Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system issues #30

Open
matthijskooijman opened this issue Nov 23, 2021 · 0 comments
Open

Build system issues #30

matthijskooijman opened this issue Nov 23, 2021 · 0 comments

Comments

@matthijskooijman
Copy link

While building the Debian package for the latest release, I came across a few issues. This is pretty much the same issue as OpenTTD/OpenSFX#47, with some minor changes.

  • The tarball contains an opensfx.obs file, but running make clean removes it, which means that make && make clean leave the build dir in a different state. Note that unlike with OpenSFX, the file is not actually regenerated/overwritten by default, since none of its requirements are missing.
  • make check does no longer work. The Makefile part that handles this seems to use grfid and expect openmsx.grf to exist, which is not the case. Makefile.config does specify MD5_SRC_FILENAME (pointing to the obm file), but that file contains more than just an md5 file, so I'm not exactly sure how this is intended. The old makefile system would ship an openmsx-0.3.1.md5 in the tarball, and then just generate md5sums of the relevant files (midi files I think) and compare those with the shipped file. What is the intention here? This is also the subject of No tests (make check) is possible #22.
  • make bundle no longer seems to work to install the bundle into $(DIR_NAME) as before (and as documented). Weirdly enough it just says "make: Nothing to be done for 'bundle'", but I can't actually find a rule for bundle (perhaps some wildcard rule or something). This rule was previously used by the Debian package to install individual files into /usr/share/games/openttd/baseset/openmsx (rather than a tarball), since there is not much point in merging files into a tarball inside a Debian package (though I'm now switching to using make install instead, which also installs separate files).
  • make install generates a tarball, but does not actually use it (instead, it installs separate files, which is what I'm using now). I think it could just depend on $(DIR_NAME) rather than $(DIR_NAME).tar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant