-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated netty to 4.x #116
base: next
Are you sure you want to change the base?
Conversation
Ah, hah, thanks! I was going to ask you to push against next but you beat me to it! I think we should push this in 1.8. 1.7 is almost done (one more bit of code I need) then we can cut it then add netty 4 to next. Would that work for you? |
Also could you sign the contributors agreement please? https://docs.google.com/forms/d/1VVqKFTYNp3btgwXE51Zf9_Sfq66yZ4JbuEFrLlTD70E/viewform?embedded=true&formkey=dFNiOFROLXJBbFBmMkQtb1hNMWhUUnc6MQ |
Just submitted. -thanks From: Chris Larsen <[email protected]mailto:[email protected]> Also could you sign the contributors agreement please? https://docs.google.com/forms/d/1VVqKFTYNp3btgwXE51Zf9_Sfq66yZ4JbuEFrLlTD70E/viewform?embedded=true&formkey=dFNiOFROLXJBbFBmMkQtb1hNMWhUUnc6MQ Reply to this email directly or view it on GitHubhttps://github.com//pull/116#issuecomment-137274085. |
Whatever is better for the project works for me. -thanks From: Chris Larsen <[email protected]mailto:[email protected]> Ah, hah, thanks! I was going to ask you to push against next but you beat me to it! I think we should push this in 1.8. 1.7 is almost done (one more bit of code I need) then we can cut it then add netty 4 to next. Would that work for you? Reply to this email directly or view it on GitHubhttps://github.com//pull/116#issuecomment-137273952. |
The buffer implementation is now determined by following properties: |
Hi there, just to know if there are plans to migrate to netty 4, i guess on the 1.8 version, is that correct? |
Rebased to 1.8.0-SNAPSHOT |
Any progress on this? We're running into version conflicts now. Anything I can do to help? |
I saw the branch has merge conflicts, so I tried to resolve them. Feel free to pull these in, if they help speed up the process: One merge commit and one fix up commit, since the merge had logical conflicts. I do have failing tests, reported by make, but the same tests seem to fail in official asynchbase/next branch. I've signed the contributor agreement. |
Any progress on this PR? Is there something I can help push this task along? |
Hi,
I have submitted a pull request for netty migration on master branch. This is the request for "next" branch.
-thanks