Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated netty to 4.x #116

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Migrated netty to 4.x #116

wants to merge 5 commits into from

Conversation

ooasis
Copy link

@ooasis ooasis commented Sep 2, 2015

Hi,

I have submitted a pull request for netty migration on master branch. This is the request for "next" branch.

-thanks

@manolama
Copy link
Member

manolama commented Sep 2, 2015

Ah, hah, thanks! I was going to ask you to push against next but you beat me to it! I think we should push this in 1.8. 1.7 is almost done (one more bit of code I need) then we can cut it then add netty 4 to next. Would that work for you?

@manolama
Copy link
Member

manolama commented Sep 2, 2015

@ooasis
Copy link
Author

ooasis commented Sep 3, 2015

Just submitted.

-thanks

From: Chris Larsen <[email protected]mailto:[email protected]>
Reply-To: OpenTSDB/asynchbase <[email protected]mailto:[email protected]>
Date: Wednesday, September 2, 2015 4:38 PM
To: OpenTSDB/asynchbase <[email protected]mailto:[email protected]>
Cc: Hang Sun <[email protected]mailto:[email protected]>
Subject: Re: [asynchbase] Migrated netty to 4.x (#116)

Also could you sign the contributors agreement please? https://docs.google.com/forms/d/1VVqKFTYNp3btgwXE51Zf9_Sfq66yZ4JbuEFrLlTD70E/viewform?embedded=true&formkey=dFNiOFROLXJBbFBmMkQtb1hNMWhUUnc6MQ

Reply to this email directly or view it on GitHubhttps://github.com//pull/116#issuecomment-137274085.

@ooasis
Copy link
Author

ooasis commented Sep 3, 2015

Whatever is better for the project works for me.

-thanks

From: Chris Larsen <[email protected]mailto:[email protected]>
Reply-To: OpenTSDB/asynchbase <[email protected]mailto:[email protected]>
Date: Wednesday, September 2, 2015 4:37 PM
To: OpenTSDB/asynchbase <[email protected]mailto:[email protected]>
Cc: Hang Sun <[email protected]mailto:[email protected]>
Subject: Re: [asynchbase] Migrated netty to 4.x (#116)

Ah, hah, thanks! I was going to ask you to push against next but you beat me to it! I think we should push this in 1.8. 1.7 is almost done (one more bit of code I need) then we can cut it then add netty 4 to next. Would that work for you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/116#issuecomment-137273952.

@ooasis
Copy link
Author

ooasis commented Sep 20, 2015

The buffer implementation is now determined by following properties:
io.netty.noPreferDirect: false to prefer off-heap and true for heap allocation. Default to false
io.netty.allocator.type: default to pooled or unpooled on Android platform

@maugomez77
Copy link

Hi there, just to know if there are plans to migrate to netty 4, i guess on the 1.8 version, is that correct?

@ooasis
Copy link
Author

ooasis commented May 6, 2016

Rebased to 1.8.0-SNAPSHOT

@stoyle
Copy link

stoyle commented Nov 22, 2016

Any progress on this? We're running into version conflicts now.

Anything I can do to help?

@stoyle
Copy link

stoyle commented Nov 22, 2016

I saw the branch has merge conflicts, so I tried to resolve them. Feel free to pull these in, if they help speed up the process:

stoyle@35fa206
stoyle@72c263c

One merge commit and one fix up commit, since the merge had logical conflicts.

I do have failing tests, reported by make, but the same tests seem to fail in official asynchbase/next branch.

I've signed the contributor agreement.

@samdvr
Copy link

samdvr commented Apr 5, 2019

Any progress on this PR? Is there something I can help push this task along?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants