Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "eager: true emits require (doesn't exist in browsers) instead of import" #58

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ArnaudWeyts
Copy link

@ArnaudWeyts ArnaudWeyts commented Oct 10, 2024

What:

Fixes #57

Why:

We expect import to be used instead of require:

const __glob__0_0 = require("./scenarios/baseline-handlebars-list.gjs");
const __glob__0_1 = require("./scenarios/baseline-inner-html.gjs");
const __glob__0_2 = require("./scenarios/ember-get.gjs");
const definedScenarios = {
  "./scenarios/baseline-handlebars-list.gjs": __glob__0_0,
  "./scenarios/baseline-inner-html.gjs": __glob__0_1,
  "./scenarios/ember-get.gjs": __glob__0_2
};

should be

import __glob__0_0 from "./scenarios/baseline-handlebars-list.gjs";
import  __glob__0_1 from "./scenarios/baseline-inner-html.gjs";
import  __glob__0_2 from "./scenarios/ember-get.gjs";
const definedScenarios = {
  "./scenarios/baseline-handlebars-list.gjs": __glob__0_0,
  "./scenarios/baseline-inner-html.gjs": __glob__0_1,
  "./scenarios/ember-get.gjs": __glob__0_2
};

This is already listed in the documentation.

How:

Adapted the transformer and tests.

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@ArnaudWeyts
Copy link
Author

@mpeyper Not sure who the right person to tag for this is, is there any feedback from you on this?

Copy link
Member

@mpeyper mpeyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This project is not being actively monitored much anymore.

I'll have to look into what is going on with the checks before merging this, but the changes look ok to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eager: true emits require (doesn't exist in browsers) instead of import.
2 participants