-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching Libby to be run via manual trigger #30248
base: integration
Are you sure you want to change the base?
Switching Libby to be run via manual trigger #30248
Conversation
|
@websterc87 that keyword didn't trigger a beta pipeline and anyway, wouldn't test the config file you changed. I'd like to wait on making such a change--removing long-existing functionality of user commenting with Libby keyword, then seeing work done in the PR--until I can get feedback from users at the upcoming EOI meeting. Or, at the very least, give them enough notice of this change. If I merged this now, it would abruptly stop that expected behavior (or until the users' feature branches get the commit) and introduce confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not taking any action on PR until discussion at the upcoming EOI meeting.
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.) |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Delivery validation checks are now included in every personal build. This target should only be used in extreme circumstances where waiting for a personal build is not sensible. Developers we running these delivery checks too often and causing confusion sometimes delivering without a passing PB. This change migrates this rarely used function to be a CI orchestrator manual trigger launchable via our cognitive ui.