Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Libby to be run via manual trigger #30248

Open
wants to merge 3 commits into
base: integration
Choose a base branch
from

Conversation

websterc87
Copy link
Member

Delivery validation checks are now included in every personal build. This target should only be used in extreme circumstances where waiting for a personal build is not sensible. Developers we running these delivery checks too often and causing confusion sometimes delivering without a passing PB. This change migrates this rarely used function to be a CI orchestrator manual trigger launchable via our cognitive ui.

@websterc87
Copy link
Member Author

websterc87 commented Nov 20, 2024

!pbbeta This failed due to bad yml (missing quotes) fixed now

@wraschke
Copy link
Member

@websterc87 that keyword didn't trigger a beta pipeline and anyway, wouldn't test the config file you changed.

I'd like to wait on making such a change--removing long-existing functionality of user commenting with Libby keyword, then seeing work done in the PR--until I can get feedback from users at the upcoming EOI meeting. Or, at the very least, give them enough notice of this change. If I merged this now, it would abruptly stop that expected behavior (or until the users' feature branches get the commit) and introduce confusion.

Copy link
Member

@wraschke wraschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not taking any action on PR until discussion at the upcoming EOI meeting.

@websterc87
Copy link
Member Author

websterc87 commented Nov 28, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 infrastructure code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 infrastructure code files were changed.

  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants