Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NumberFormatException for EA Javas in some TCKs #30228

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

Fix NumberFormatException for EA Javas in some TCKs #30228

wants to merge 1 commit into from

Conversation

gjwatts
Copy link
Member

@gjwatts gjwatts commented Nov 19, 2024

Fixes #30227

@gjwatts gjwatts self-assigned this Nov 19, 2024
@gjwatts
Copy link
Member Author

gjwatts commented Nov 19, 2024

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=e8f894c9-f82b-4d11-9eaf-48755bd3aad9

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • Please describe in a separate comment how you tested your changes.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_PZXBcKZKEe-WbLf72iZSEQ

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=e8f894c9-f82b-4d11-9eaf-48755bd3aad9 completed successfully!

@gjwatts gjwatts force-pushed the fix-number-format-exception-for-ea-java-in-TCKs branch from 3c06621 to 10b98d1 Compare November 23, 2024 01:38
@gjwatts
Copy link
Member Author

gjwatts commented Nov 23, 2024

!build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=317d1073-5461-485d-b8b1-cb32b6aafe8e

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6f13c2c2-35a1-4c64-999f-7f62dcd0ec28

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6f13c2c2-35a1-4c64-999f-7f62dcd0ec28 completed successfully!

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=317d1073-5461-485d-b8b1-cb32b6aafe8e completed successfully!

yasmin-aumeeruddy
yasmin-aumeeruddy approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@yasmin-aumeeruddy yasmin-aumeeruddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Emily-Jiang
Copy link
Member

I think it is better to pull in the MP FT 4.1.1 as it has the update as well. I am going to release MPF 2.0.1 later today. It's better to pull in the version this week rather than fixing our codebase.

@Emily-Jiang
Copy link
Member

Please pull in MP FT 4.1.1 and MPTelemetry 2.0.1, which has the fix you need.

jhanders34
jhanders34 reviewed Nov 26, 2024
View reviewed changes
...o.openliberty.microprofile.faulttolerance.4.1.internal_fat_tck/publish/tckRunner/tck/pom.xml
<dependency>
<groupId>org.eclipse.microprofile.fault-tolerance</groupId>
<artifactId>microprofile-fault-tolerance-tck</artifactId>
<version>${microprofile.faulttolerance.version}</version>
<exclusions>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<exclusions>
<exclusions>

jhanders34
jhanders34 reviewed Nov 26, 2024
View reviewed changes
dev/io.openliberty.microprofile.telemetry.2.0.internal_fat_tck/publish/tckRunner/tck/pom.xml
<dependency>
<groupId>org.eclipse.microprofile.telemetry</groupId>
<artifactId>microprofile-telemetry-tracing-tck</artifactId>
<version>${mptelemetry.version}</version>
<exclusions>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<exclusions>
<exclusions>

jhanders34
jhanders34 reviewed Nov 26, 2024
View reviewed changes
dev/io.openliberty.microprofile.telemetry.2.0.internal_fat_tck/publish/tckRunner/tck/pom.xml
</dependency>
<dependency>
<groupId>org.eclipse.microprofile.telemetry</groupId>
<artifactId>microprofile-telemetry-metrics-tck</artifactId>
<version>${mptelemetry.version}</version>
<exclusions>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<exclusions>
<exclusions>

jhanders34
jhanders34 reviewed Nov 26, 2024
View reviewed changes
dev/io.openliberty.microprofile.telemetry.2.0.internal_fat_tck/publish/tckRunner/tck/pom.xml
</dependency>
<dependency>
<groupId>org.eclipse.microprofile.telemetry</groupId>
<artifactId>microprofile-telemetry-logs-tck</artifactId>
<version>${mptelemetry.version}</version>
<exclusions>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<exclusions>
<exclusions>

@jhanders34
Copy link
Member

Please pull in MP FT 4.1.1 and MPTelemetry 2.0.1, which has the fix you need.

Of course those were just published today. Couldn't move to them last week since they didn't exist.

@gjwatts when you are back in the office after the holiday, this change gets much easier.

jhanders34
jhanders34 requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@jhanders34 jhanders34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light of new versions of the TCK available with the updated awaitility, the change gets much simpler and doesn't require any overriding of dependencies.

@gjwatts
Copy link
Member Author

gjwatts commented Nov 26, 2024

@jhanders34 Thank you for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhanders34 jhanders34 jhanders34 requested changes

@yasmin-aumeeruddy yasmin-aumeeruddy yasmin-aumeeruddy approved these changes

@benjamin-confino benjamin-confino benjamin-confino approved these changes

@Emily-Jiang Emily-Jiang Awaiting requested review from Emily-Jiang

Requested changes must be addressed to merge this pull request.

Assignees

@gjwatts gjwatts

Labels
CLA Signed noproductcode team:Zombie Apocalypse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some TCKs use a version of awaitility that does not handle early access versions of Java
6 participants
@gjwatts @LibbyBot @Emily-Jiang @jhanders34 @benjamin-confino @yasmin-aumeeruddy