-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configdropins info to server config overview #7031
Comments
7031-configdropins info to server config overview-1 #7031
Hi David, I added the suggested information to the Server Configuration Overview Document. Regards, |
Looks good, except the title of the section is not parallel with other titles in this topic. Looking more closely at the topic, I see there is already some info about configdropins, including the precedence in the section for the server.xml file: https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/reference/config/server-configuration-overview.html#server-xml I think we can just incorporate the info from the new section there, without needing to make a separate section,. Since the precedence and the definition are already in this section, all we really need is the information from the "Types of subdirectories within configDropins" secxtion, which I think cpuld be integrated into the server.xml section without needing it's own heading |
7031-configdropins info to server config overview-2 #7031
Hi David, I made the suggested changes to the document. I removed the section that was added and made modifications in the Server.xml section to add the suggested information. Regards, |
LGTM- I do see a few small acrolinx issues. If you run acrolinx on the updated text and fix what you can, I think it's ready to go to staging. |
7031-configdropins info to server config overview-3 #7031
7031-configdropins info to server config overview-4 #7031
7031-configdropins info to server config overview-5 #7031
Hi David, Acrolinx issues fixed. Regards, |
looks good except- Formatting on monospace code terms is messed up here: Configurations in the Also- their order of processing can be inconsistent. |
7031-configdropins info to server config overview-6 #7031
Hi David, The suggested corrections are done. Regards, |
LGTM- I think it can go to staging |
Migrate WAS Liberty docs for configDropins info to Server config overview.
The text was updated successfully, but these errors were encountered: