Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configdropins info to server config overview #7031

Closed
dmuelle opened this issue Nov 6, 2023 · 8 comments · Fixed by #7130
Closed

add configdropins info to server config overview #7031

dmuelle opened this issue Nov 6, 2023 · 8 comments · Fixed by #7130
Assignees
Milestone

Comments

@dmuelle
Copy link
Member

dmuelle commented Nov 6, 2023

Migrate WAS Liberty docs for configDropins info to Server config overview.

  • create a new section just after "include processing"
  • make the info match the styloe of the server config overview instead of "task" format.
  • confirm w/ dev whether configDropins is intended for prod use or just dev/test and clarify in doc if needed.
@dmuelle dmuelle added this to the 23.0.0.12 milestone Nov 6, 2023
ramkumar-k-9286 added a commit that referenced this issue Nov 20, 2023
7031-configdropins info to server config overview-1

#7031
@ramkumar-k-9286
Copy link
Contributor

@dmuelle

Hi David,

I added the suggested information to the Server Configuration Overview Document.

Draft link:
https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/reference/config/server-configuration-overview.html

Regards,
Ramkumar.

@dmuelle
Copy link
Member Author

dmuelle commented Nov 20, 2023

Looks good, except the title of the section is not parallel with other titles in this topic. Looking more closely at the topic, I see there is already some info about configdropins, including the precedence in the section for the server.xml file: https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/reference/config/server-configuration-overview.html#server-xml

I think we can just incorporate the info from the new section there, without needing to make a separate section,. Since the precedence and the definition are already in this section, all we really need is the information from the "Types of subdirectories within configDropins" secxtion, which I think cpuld be integrated into the server.xml section without needing it's own heading

ramkumar-k-9286 added a commit that referenced this issue Nov 21, 2023
7031-configdropins info to server config overview-2

#7031
@ramkumar-k-9286
Copy link
Contributor

@dmuelle

Hi David,

I made the suggested changes to the document. I removed the section that was added and made modifications in the Server.xml section to add the suggested information.

Draft link:
https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/reference/config/server-configuration-overview.html#server-xml

Regards,
Ramkumar.

@dmuelle
Copy link
Member Author

dmuelle commented Nov 21, 2023

LGTM- I do see a few small acrolinx issues. If you run acrolinx on the updated text and fix what you can, I think it's ready to go to staging.

ramkumar-k-9286 added a commit that referenced this issue Nov 23, 2023
7031-configdropins info to server config overview-3

#7031
ramkumar-k-9286 added a commit that referenced this issue Nov 24, 2023
7031-configdropins info to server config overview-4

#7031
ramkumar-k-9286 added a commit that referenced this issue Nov 24, 2023
7031-configdropins info to server config overview-5

#7031
@ramkumar-k-9286
Copy link
Contributor

@dmuelle
Copy link
Member Author

dmuelle commented Nov 27, 2023

looks good except-

Formatting on monospace code terms is messed up here:

Configurations in the configDropins/overrides directory take precedence over configurations in the server.xml file, which in turn take precedence over configurations in the configDropins/defaults directory. The configurations in 'configDropins/overrides' and 'configDropins/defaults' supersede any default settings a feature specifies.

Also-

their order of processing can be inconsistent.
--->
their order of processing might be inconsistent.

ramkumar-k-9286 added a commit that referenced this issue Nov 27, 2023
7031-configdropins info to server config overview-6

#7031
@ramkumar-k-9286
Copy link
Contributor

@dmuelle
Copy link
Member Author

dmuelle commented Nov 28, 2023

LGTM- I think it can go to staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants